This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Restore leading zeros in remote_thread_alive


Pedro Alves wrote:
On Wednesday 22 October 2008 19:05:09, Michael Snyder wrote:
Pedro Alves wrote:

Could you try this out please?  It works here against gdbserver
single|multi-process, and sends a `T000000tid' (tid alive) packet when
multi-process isn't in effect.
Thanks for working up the patch -- it works for my target.

Thanks for testing.


However, I must say that I'm not crazy about the idea that
we decide whether or not to send leading zeroes based on
whether the target is multi-process.  Seems orthogonal
and ad hoc.

I can't think of a valid reason why we'd have this inconsistency:

Yeah -- Pedro, I'm going to withdraw the request. I decided to fix the client (breakage was worse than I thought -- it was actually discarding the first byte of data, which only succeeded because it happened to be zero).

I don't think it's necessary to uglify remote.c to
handle this issue, unles someone else reports a problem
with it -- but I leave the decision up to you.  ;-)

Thanks for your trouble,
Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]