This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] static_kind -> bit0, bit1 [Re: [gdb] Fortran dynamic arrays]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org, Tobias Burnus <burnus at net-b dot de>, Ulrich Weigand <uweigand at de dot ibm dot com>, Jim Blandy <jimb at red-bean dot com>
- Date: Wed, 8 Oct 2008 14:52:23 +0200
- Subject: Re: [patch] static_kind -> bit0, bit1 [Re: [gdb] Fortran dynamic arrays]
- References: <20080818111120.GE16894@adacore.com> <200808181553.m7IFrG3w005270@d12av02.megacenter.de.ibm.com> <48A59B3C.9050801@net-b.de> <20080818111120.GE16894@adacore.com> <20080907115637.GA12939@host0.dyn.jankratochvil.net> <20080919221221.GA23372@adacore.com> <20081004202457.GA20726@host0.dyn.jankratochvil.net> <20081006200001.GC3588@adacore.com> <20081007225538.GA1206@host0.dyn.jankratochvil.net> <20081008032731.GE3810@adacore.com>
On Wed, 08 Oct 2008 05:27:31 +0200, Joel Brobecker wrote:
> [in copy_type_recursive]
> > + break;
> > + default:
> > + gdb_assert (0);
>
> Can you change that to using an internal_error, instead? For instance,
>
> internal_error (__FILE__, __LINE__, _("Unexpected ... kind: %d"),
> TYPE_FIELD_LOC_KIND (type, i));
>
> Something like that.
Used:
+ internal_error (__FILE__, __LINE__,
+ _("Unexpected type field location kind: %d"),
+ TYPE_FIELD_LOC_KIND (type, i));
And committed:
http://sourceware.org/ml/gdb-cvs/2008-10/msg00099.html
Going to post the real parts of the patchset rebased on this change and split.
Thanks,
Jan