This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] static_kind -> bit0, bit1 [Re: [gdb] Fortran dynamic arrays]


On Wed, 08 Oct 2008 05:27:31 +0200, Joel Brobecker wrote:
> [in copy_type_recursive]
> > +	      break;
> > +	    default:
> > +	      gdb_assert (0);
> 
> Can you change that to using an internal_error, instead? For instance,
> 
>      internal_error (__FILE__, __LINE__, _("Unexpected ... kind: %d"),
>                      TYPE_FIELD_LOC_KIND (type, i));
> 
> Something like that.

Used:
+	      internal_error (__FILE__, __LINE__,
+			      _("Unexpected type field location kind: %d"),
+			      TYPE_FIELD_LOC_KIND (type, i));

And committed:
	http://sourceware.org/ml/gdb-cvs/2008-10/msg00099.html

Going to post the real parts of the patchset rebased on this change and split.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]