[commit/Ada] Do not search the minimal symbol during symbol lookup

[Joel Brobecker <brobecker at adacore dot com>]

This patch further improves symbol lookup performance by another 10%,
mostly by removing a loop that appears to be useless except working
around an issue with nested subprograms in partial symtabs. I just
posted a patch to fix the issue, so this code can go as soon as the
other patch is committed. See: http://www.sourceware.org/ml/gdb-patches/2008-09/msg00224.html.

We took the opportunity to split the ada_lookup_symbol_list function
into small functions to make the code a little clearer (actually,
a lot clearer to me).

2008-09-10  Joel Brobecker  <brobecker@adacore.com>

        * ada-lang.c (remove_extra_symbols): Remove stub symbols if
        the associated complete symbol is also in the list.
        (ada_add_local_symbols, ada_add_non_local_symbols): New functions,
        extracted out from ada_lookup_symbol_list.
        (ada_lookup_symbol_list): Use them.  Remove the search through
        the minimal symbols.

Tested on x86-linux. Will be checked in if/when the patch on which
this depends in checked in as well.

-- 
Joel

Attachment: 04-perf2.diff
Description: Text document