This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Fix python indented multi-line commands
On Thu, Aug 14, 2008 at 04:38:27PM -0300, Thiago Jung Bauermann wrote:
> On Thu, 2008-08-14 at 22:20 +0300, Eli Zaretskii wrote:
> > > From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> > > Cc: gdb-patches@sources.redhat.com, Daniel Jacobowitz <drow@false.org>
> > > Date: Thu, 14 Aug 2008 00:55:23 -0300
> > >
> > > > Please don't call variables by mysterious names such as
> > > > "special_processing". Please give that variable a meaningful name
> > > > that would explain the purpose of this flag even without reading the
> > > > code of the callers of this function.
> > >
> > > I agree. The argument has two effects though (stripping of leading
> > > whitespace, and recognizing GDB control commands), so I had some
> > > difficulty in finding a meaningful name for it. That's why I left it
> > > with that one. It is now called parse_input, what do you think?
> >
> > "parse_commands"? Or maybe "only_end_cmd" (and reverse the tests)?
>
> parse_commands is good. Do we have a deal? :-)
Yes, I think that sounds right.
--
Daniel Jacobowitz
CodeSourcery