Re: [rfc/rfa] Retrieve libraries from remote target

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Wed, 13 Aug 2008 21:53:58 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> Cc: drow@false.org, eliz@gnu.org
> 
> here is an updated version of the patch to have GDB automatically retrieve
> shared libraries from the remote target:
> http://sourceware.org/ml/gdb-patches/2008-05/msg00287.html

Thanks!

> +configurations.  GDB needs to have access to the target's libraries;
> +this can be accomplished either by providing copies of the libraries
> +on the host system, or by asking GDB to automatically retrieve the
> +libraries from the target.  If copies of the target libraries are
> +provided, they need to be the same as the target libraries, although the

Please use @value{GDBN}", rather than a literal "GDB", here and
elsewhere in your patch for the manual.

> +If @var{path} starts with the sequence @file{remote:}, GDB will 
> +retrieve the target libraries from the remote system.  This is only
> +supported when using a remote target that supports the @code{remote get}
> +command.

It would be useful to add a cross-reference here to where "remote get"
is described in the manual.

> +* GDB now supports automatically retrieving shared library files from remote
> +targets by using the `remote:' prefix on a system root path specified via
> +the `set setroot' command or the `--with-sysroot' configure option.

First, you probably meant "set sysroot", not "set setroot".

More importantly, this sentence should be rephrased, e.g.:

 +* GDB now supports automatic retrieval of shared library files from
 +remote targets.  To use this feature, specify a system root that begins
 +with the `remote:' prefix, either via the `set sysroot' command or via
 +the `--with-sysroot' configure-time option.

As written, the sentence in effect says that it's GDB who uses the
`remote:' prefix, which is probably not what you mean.

Other than that, the doco patches are approved.