This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix python indented multi-line commands


> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sources.redhat.com, Daniel Jacobowitz <drow@false.org>
> Date: Thu, 14 Aug 2008 00:55:23 -0300
> 
> > Please don't call variables by mysterious names such as
> > "special_processing".  Please give that variable a meaningful name
> > that would explain the purpose of this flag even without reading the
> > code of the callers of this function.
> 
> I agree. The argument has two effects though (stripping of leading
> whitespace, and recognizing GDB control commands), so I had some
> difficulty in finding a meaningful name for it. That's why I left it
> with that one. It is now called parse_input, what do you think?

"parse_commands"?  Or maybe "only_end_cmd" (and reverse the tests)?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]