This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Whack solib breakpoint symbol bits


solib-svr4.c has some old unused defines; one of them, SOLIB_BKPT_NAME, seems to have been added by Fred Fish in 1992 as part of new code, in the expectation that someone might need it eventually - but after 16 years of non-use, I think it's safe to say it's not going to happen. :-)

Stan

2008-08-04 Stan Shebs <stan@codesourcery.com>

   * solib-svr4.c (BKPT_AT_SYMBOL): Remove, always defined.
   (bkpt_names): Remove SOLIB_BKPT_NAME, never defined.
   (enable_break): Remove test of BKPT_AT_SYMBOL.

Index: solib-svr4.c
===================================================================
RCS file: /cvs/src/src/gdb/solib-svr4.c,v
retrieving revision 1.87
retrieving revision 1.88
diff -u -p -r1.87 -r1.88
--- solib-svr4.c    3 Jun 2008 12:59:37 -0000    1.87
+++ solib-svr4.c    5 Aug 2008 00:16:23 -0000    1.88
@@ -85,20 +85,13 @@ static char *solib_break_names[] =
  NULL
};

-#define BKPT_AT_SYMBOL 1
-
-#if defined (BKPT_AT_SYMBOL)
static char *bkpt_names[] =
{
-#ifdef SOLIB_BKPT_NAME
-  SOLIB_BKPT_NAME,        /* Prefer configured name if it exists. */
-#endif
  "_start",
  "__start",
  "main",
  NULL
};
-#endif

static char *main_name_list[] =
{
@@ -967,8 +960,6 @@ exec_entry_point (struct bfd *abfd, stru
static int
enable_break (void)
{
-#ifdef BKPT_AT_SYMBOL
-
  struct minimal_symbol *msymbol;
  char **bkpt_namep;
  asection *interp_sect;
@@ -1203,8 +1194,6 @@ enable_break (void)
      return 1;
    }
    }
-#endif /* BKPT_AT_SYMBOL */
-
  return 0;
}



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]