This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.

From: "=?big5?b?RG91ZyBLd2FuICjD9q62vHcp?=" <dougkwan at google dot com>
To: "Michael Snyder" <msnyder at specifix dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 23 Jul 2008 01:29:33 -0700
Subject: Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.
References: <498552560807221759w1ade0ec2jd63c12475ddb5217@mail.gmail.com> <1216784910.3549.496.camel@localhost.localdomain>

Hi,

2008/7/22 Michael Snyder <msnyder@specifix.com>:

> I'm surprised by some of the diffs in the generated configure
> script -- wonder if you used a different version of autoconf
> or something?

I don't know.  My autoconf claims to be 2.59 and the original
configure is generated by autoconf 2.59 also.

> Otherwise looks pretty OK.
> I don't know enough to say whether STDC_HEADERS is the right
> ifdef for the errno change in linux_write_memory.

This is done in gdbreplay.c also.  I assume that's the correct way to
do it. But it's moot now as another reviewer suggests removing the
declaration altogether.

-Doug

References:
- [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.
  - From: =?big5?b?RG91ZyBLd2FuICjD9q62vHcp?=
- Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in configuration.
  - From: Michael Snyder

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]