This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[nto target] Fix compiler warnings.
- From: Aleksandar Ristovski <aristovski at qnx dot com>
- To: gdb-patches at sources dot redhat dot com
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Tue, 22 Jul 2008 15:56:41 -0400
- Subject: [nto target] Fix compiler warnings.
Hello Ulrich,
Instead of extensive patch I tried last time, this one is simple and merely fixes compiler warnings (I get the warnings with gcc 4.2.*).
Note that the type-punned pointer warning is fixed in a simpler way (as opposed to union I did the last time).
Please review.
Thanks,
Aleksandar
ChangeLog:
2008-07-22 Aleksandar Ristovski <aristovski@qnx.com>
* nto-procfs.c (procfs_xfer_memory): Changed signature.
(procfs_resume): Workaround for dereferencing type-punned pointer
warning.
* nto-tdep.c (nto_parse_redirection): Change signature to be const
correct.
* nto-tdep.h (nto_parse_redirection): Likewise.
Index: gdb/nto-procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/nto-procfs.c,v
retrieving revision 1.27
diff -u -p -r1.27 nto-procfs.c
--- gdb/nto-procfs.c 9 Jul 2008 22:49:56 -0000 1.27
+++ gdb/nto-procfs.c 22 Jul 2008 19:37:13 -0000
@@ -61,7 +61,7 @@ static int procfs_can_run (void);
static ptid_t procfs_wait (ptid_t, struct target_waitstatus *);
-static int procfs_xfer_memory (CORE_ADDR, char *, int, int,
+static int procfs_xfer_memory (CORE_ADDR, gdb_byte *, int, int,
struct mem_attrib *attrib,
struct target_ops *);
@@ -744,7 +744,7 @@ procfs_fetch_registers (struct regcache
doesn't allow memory operations to cross below us in the target stack
anyway. */
static int
-procfs_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int dowrite,
+procfs_xfer_memory (CORE_ADDR memaddr, gdb_byte *myaddr, int len, int dowrite,
struct mem_attrib *attrib, struct target_ops *target)
{
int nbytes = 0;
@@ -838,6 +838,7 @@ procfs_resume (ptid_t ptid, int step, en
{
int signal_to_pass;
procfs_status status;
+ sigset_t *run_fault = (sigset_t *) (void *) &run.fault;
if (ptid_equal (inferior_ptid, null_ptid))
return;
@@ -849,17 +850,17 @@ procfs_resume (ptid_t ptid, int step, en
if (step)
run.flags |= _DEBUG_RUN_STEP;
- sigemptyset ((sigset_t *) &run.fault);
- sigaddset ((sigset_t *) &run.fault, FLTBPT);
- sigaddset ((sigset_t *) &run.fault, FLTTRACE);
- sigaddset ((sigset_t *) &run.fault, FLTILL);
- sigaddset ((sigset_t *) &run.fault, FLTPRIV);
- sigaddset ((sigset_t *) &run.fault, FLTBOUNDS);
- sigaddset ((sigset_t *) &run.fault, FLTIOVF);
- sigaddset ((sigset_t *) &run.fault, FLTIZDIV);
- sigaddset ((sigset_t *) &run.fault, FLTFPE);
+ sigemptyset (run_fault);
+ sigaddset (run_fault, FLTBPT);
+ sigaddset (run_fault, FLTTRACE);
+ sigaddset (run_fault, FLTILL);
+ sigaddset (run_fault, FLTPRIV);
+ sigaddset (run_fault, FLTBOUNDS);
+ sigaddset (run_fault, FLTIOVF);
+ sigaddset (run_fault, FLTIZDIV);
+ sigaddset (run_fault, FLTFPE);
/* Peter V will be changing this at some point. */
- sigaddset ((sigset_t *) &run.fault, FLTPAGE);
+ sigaddset (run_fault, FLTPAGE);
run.flags |= _DEBUG_RUN_ARM;
Index: gdb/nto-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/nto-tdep.c,v
retrieving revision 1.24
diff -u -p -r1.24 nto-tdep.c
--- gdb/nto-tdep.c 29 Jan 2008 21:26:04 -0000 1.24
+++ gdb/nto-tdep.c 22 Jul 2008 19:37:13 -0000
@@ -196,7 +196,8 @@ nto_init_solib_absolute_prefix (void)
}
char **
-nto_parse_redirection (char *pargv[], char **pin, char **pout, char **perr)
+nto_parse_redirection (char *pargv[], const char **pin, const char **pout,
+ const char **perr)
{
char **argv;
char *in, *out, *err, *p;
Index: gdb/nto-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/nto-tdep.h,v
retrieving revision 1.9
diff -u -p -r1.9 nto-tdep.h
--- gdb/nto-tdep.h 29 Jan 2008 21:26:04 -0000 1.9
+++ gdb/nto-tdep.h 22 Jul 2008 19:37:13 -0000
@@ -144,8 +144,8 @@ void nto_init_solib_absolute_prefix (voi
void nto_set_target(struct nto_target_ops *);
-char **nto_parse_redirection (char *start_argv[], char **in,
- char **out, char **err);
+char **nto_parse_redirection (char *start_argv[], const char **in,
+ const char **out, const char **err);
int proc_iterate_over_mappings (int (*func) (int, CORE_ADDR));