This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GDB/MI PING (was: "Re: RFA: Remove gdb-events")


Hi Vladimir,

Tom made some changes in MI source files. They should not affect MI
behavior at all, and they look fine to me, but I thought you might
want to have a look.

    http://www.sourceware.org/ml/gdb-patches/2008-07/msg00244.html

Hey Tom,

> Joel> Eli: if you could take a look at the documentation of the new
> Joel> observers, that would be great! I'm going to approve the
> Joel> technical part, and we'll follow any suggestion you might have
> Joel> either before or after commit.
> 
> Joel> Vladimir: This patch touches MI. Could you take a look at this part
> Joel> of the patch? The changes seem fine to me, but see below my suggestion.
> 
> I'm waiting for these two, so I haven't sent an updated patch.
> But...

I see Eli answered, so let's now wait for Vladimir - I think he just
missed this email (so I changed the subject to contain "MI" to catch
his attention).

> I checked and all the dependencies are there, afaict.  I think you
> just misread the tracepoint.o hunk.  See the second insertion:

Argh, you are right. Sorry about that.

You should commit your change as soon as Vladimir OKs the MI part.
I'm almost tempted to say that you should commit them now, and fix
any comment that Vladimir might have as a followup patch, but Vladimir
is usually extremely responsive.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]