This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] Rename frame_pc_unwind and frame_unwind_id
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: drow at false dot org
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 15 Jul 2008 21:08:34 +0200 (CEST)
- Subject: Re: [commit] Rename frame_pc_unwind and frame_unwind_id
- References: <20080715190125.GC32644@caradoc.them.org>
> Date: Tue, 15 Jul 2008 15:01:25 -0400
> From: Daniel Jacobowitz <drow@false.org>
>
> This patch is the first non-trivial change in inlining support, and
> readily separable.
Non-trivial...
> The users of frame_unwind_id and frame_pc_unwind are all either
> inferior control, trying to find the caller / return address of a new
> function, or trampoline handling. I audited all of the uses, and the
> right behavior in every one of them is to ignore any inlined functions
> at the current location. A future patch, the one adding inlined
> frames, will make the corresponding change to frame_unwind_caller_id
> and frame_unwind_caller_pc. For now, I've just renamed them to
> indicate the correct expectations.
...so cann't we discuss this first please?