This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: Patch: annotations -vs- deprecated hooks
>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:
>> Is it just annotations that you care about, or all the deprecated hook
>> stuff? I think it all falls into the category of not-broken.
Nick> Emacs still uses annotations and it seems to work OK. Your
Nick> earlier change, emoving event hooks, removes a significant
Nick> amount of code and stops others from using them in the future.
I think this change is worthwhile as a cleanup. It removes some
more deprecated things, preventing use of them.
When browsing gdb, I find it very strange to see how many things are
marked deprecated, and for how long. E.g.,
deprecated_annotate_starting_hook is not set anywhere in gdb, but has
been deprecated since 2004. That seems like an inordinately long
deprecation for something which is unused.
Nick> This patch, however, while probably safe (I've not checked)
Nick> doesn't seem worthwhile to me since this code _will_ disappear
Nick> in the future anyway.
Do you know when this will be? If it is soon, then I don't mind
holding off. If it will be a year, or years, then I think it would be
strange to reject a cleanup in favor of some distant, unwritten patch.
Tom