This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [MI non-stop 04/11] Implement --thread and --frame.


> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 28 Jun 2008 20:44:14 +0400
> 
> 
> +  if (parse->frame != -1 && !parse->thread == -1)
> +    error ("Cannot specify --frame without --thread");

Why is this error message not in _(), while all the rest are?

Btw, do we at all want error messages issued by MI commands
translated?  MI commands are invoked by a program, so error messages
we generate should be understandable by a program, which probably
means they should not be translated.

> +      if (strncmp (chp, "--thread", 8) == 0)

Please, let's not use literal constants in this context, let's use
sizeof instead.

> +	  parse->frame = strtol (chp, &chp, 10);

Do we really want to disallow non-decimal numbers here?  What about
hex frame numbers?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]