This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Remove undocumented remote procotol extension
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 11 Jun 2008 01:03:33 +0100
- Subject: Remove undocumented remote procotol extension
Hi,
Following up on,
[remote] Where is S AA p PID currently specified?
http://sourceware.org/ml/gdb/2008-06/msg00081.html
Here is the patch that removes the undocumented extension.
Is this NEWS worthy? If so, NEWS change included.
OK ?
--
Pedro Alves
2008-06-11 Pedro Alves <pedro@codesourcery.com>
* NEW: Mention support removal for undocumented S AA p PID stop
reply packet.
* remote.c (remote_wait): Remove undocumented S AA p PID support.
---
gdb/NEWS | 6 ++++++
gdb/remote.c | 6 ------
2 files changed, 6 insertions(+), 6 deletions(-)
Index: src/gdb/NEWS
===================================================================
--- src.orig/gdb/NEWS 2008-06-11 00:47:26.000000000 +0100
+++ src/gdb/NEWS 2008-06-11 00:52:20.000000000 +0100
@@ -19,6 +19,12 @@ completions will be "f1" and "f2".
qSearch:memory:
Search memory for a sequence of bytes.
+* Removed remote protocol undocumented extension
+
+ An undocumented extension to the remote protocol's `S' stop reply
+ packet that permited the stub to pass a process id was removed.
+ Remote servers shall use the `T' stop reply packet instead.
+
* The "disassemble" command now supports an optional /m modifier to print mixed
source+assembly.
Index: src/gdb/remote.c
===================================================================
--- src.orig/gdb/remote.c 2008-06-11 00:46:09.000000000 +0100
+++ src/gdb/remote.c 2008-06-11 00:46:52.000000000 +0100
@@ -3523,12 +3523,6 @@ Packet: '%s'\n"),
status->value.sig = (enum target_signal)
(((fromhex (buf[1])) << 4) + (fromhex (buf[2])));
}
-
- if (buf[3] == 'p')
- {
- thread_num = strtol ((const char *) &buf[4], NULL, 16);
- record_currthread (thread_num);
- }
goto got_status;
case 'W': /* Target exited. */
{