This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Fix for mishandling of "break 'pthread_create@GLIBC_2.2.5'"
- From: "Paul Pluzhnikov" <ppluzhnikov at google dot com>
- To: "Paul Pluzhnikov" <ppluzhnikov at google dot com>, gdb-patches at sourceware dot org, "Doug Evans" <dje at google dot com>, "Michael Snyder" <msnyder at specifix dot com>
- Date: Thu, 5 Jun 2008 19:14:25 -0700
- Subject: Re: [RFC] Fix for mishandling of "break 'pthread_create@GLIBC_2.2.5'"
- References: <8ac60eac0805131135h5e9dd46ev8b7f39e660bf0bb7@mail.gmail.com> <20080513184447.GA12349@caradoc.them.org> <8ac60eac0805131351s241d33a8pd7d9839c51e53a8d@mail.gmail.com> <20080513205941.GA21147@caradoc.them.org> <8ac60eac0805131411q443b8f3awa464e090a5a44aaf@mail.gmail.com> <8ac60eac0805131805m6216660ej7b8e859ce46cb084@mail.gmail.com> <20080605191340.GB25085@caradoc.them.org>
On Thu, Jun 5, 2008 at 12:13 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Tue, May 13, 2008 at 06:05:05PM -0700, Paul Pluzhnikov wrote:
>> So the expression evaluation and the breakpoint evaluation go
>> completely separate routes:
>
> Ah, right. I tried nested functions in GCC, which have the same
> problem.
Yes, and the same fix should fix that as well :)
>> set_flags (*argptr, &is_quoted, &paren_pointer);
>>
>> - /* Check to see if it's a multipart linespec (with colons or
>> - periods). */
>> + if ((*argptr)[0] == '\'')
>
> I believe this is the same as is_quoted.
You are correct.
> If I'm right, that implies that this breaks:
>
> (gdb) break 'foo.c':13
But that is *already* broken:
(gdb) b t.c:8
Breakpoint 1 at 0x400308: file t.c, line 8.
(gdb) b "t.c":8
Breakpoint 2 at 0x400308: file t.c, line 8.
(gdb) b 't.c':8
No source file named t.c'.
(gdb)
I can fix that (and I believe it should be fixed), but it appears
that single and double quotes are treated quite differently in
linespec.c
Is there maybe a reason for this?
> We need to call locate_first_half to separate the filename from the
> line number. There's also the 'foo.c'::staticvar form to worry about.
That case already works correctly (remember -- variables go through
totally different path).
> I think locate_first_half is going to have to know whether is_quoted,
> and if so, only look for the matching quote.
Something like this:
@@ -1003,7 +1003,9 @@ locate_first_half (char **argptr, int *i
/* Maybe arg is FILE : LINENUM or FILE : FUNCTION. May also be
CLASS::MEMBER, or NAMESPACE::NAME. Look for ':', but ignore
- inside of <>. */
+ inside of <>.
+ May also be 'FILE' : LINENUM, or 'symbol@VERSION'. Ignore
+ any ':' or '.' inside single qoutes. */
p = *argptr;
if (p[0] == '"')
@@ -1014,6 +1016,17 @@ locate_first_half (char **argptr, int *i
}
else
*is_quote_enclosed = 0;
+
+ if (p[0] == '\'')
+ {
+ char *q = p + 1;
+ for (; *q && q[0] != '\''; q++) { }
+ if (q[0] == '\'')
+ q++;
+ else
+ error (_("missing closing quote in command"));
+ p = q;
+ }
for (; *p; p++)
{
if (p[0] == '<')
--
Paul Pluzhnikov