This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Changes to varobj.c


I apologise if I missed it, but I never saw a patch for the change below.

I can see a stale comment before varobj_update:

   NOTE: This function may delete the caller's varobj. If it
   returns TYPE_CHANGED,...

(varobj_update no longer returns TYPE_CHANGED)

2008-05-28  Vladimir Prus  <vladimir@codesourcery.com>

	Refactor varobj_update interface.
        * varobj.c (varobj_update): Report changes as vector.  Also
        return not just a list of varobj, but a list of special structures
        that tell what exactly has changed.
        * varobj.h (enum varobj_update_error): Rename to
        varobj_scope_status.
        (struct varobj_update_result_t): New.
        (varobj_update): Adjust prototype.
        * mi/mi-cmd-var.c: Adjust for changes.
                           ^^^^^^^^^^^^^^^^^^

It's usual to include the name of changed function in the ChangeLog.

If you want a second pair of eyes, I'm more likely to peer review patches than
changes that have already been comitted

-- 
Nick                                           http://www.inet.net.nz/~nickrob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]