This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Patch: implement missing macro functions

> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Fri, 23 May 2008 15:07:56 -0600
> 
> I fixed all the macro-related uses of @command.

Thanks.

> Here's a new patch.  Let me know what you think.

It's okay, but for a single minor nit:

> +macro define
> +macro list
> +macro undef
> +  These commands are now implemented.  These allow macros to be
> +  defined, undefined, and listed interactively.

I think we should delete the first sentence.  Users who read NEWS do
not know that these commands were documented, but not implemented.
Just saying "These commands allow macros to be defined, undefined, and
listed interactively from within GDB." is enough

Thanks.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]