This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Report the main thread.
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 10 May 2008 17:02:57 +0400
- Subject: Re: [RFA] Report the main thread.
- References: <18469.39280.284106.858072@kahikatea.snap.net.nz>
Nick Roberts wrote:
>
>> Vladimir Prus wrote:
>
>>> Daniel Jacobowitz wrote:
>>>
>>>> On Sat, Apr 26, 2008 at 08:44:23PM +0400, Vladimir Prus wrote:
>>>>> Will some approach that only produce MI output be fine with you?
>>>>
>>>> Perhaps that means any observer for a new MI thread should go in
>>>> add_thread_silent?
>>>
>>> Yes, moving the observer call to add_thread_silent is the most
>>> direct approach to make MI work the way I want without disturbing CLI.
>
>> Here's a patch to that effect. OK?
>
>> * thread.c (add_thread): Move observer call to ...
>> (add_thread_silent): ... here.
>> ---
>> gdb/thread.c | 5 +++--
>> > 1 files changed, 3 insertions(+), 2 deletions(-)
>
>> diff --git a/gdb/thread.c b/gdb/thread.c
>> index 46e6ba7..d3cfb32 100644
>> --- a/gdb/thread.c
>> +++ b/gdb/thread.c
>> @@ -124,6 +124,9 @@ add_thread_silent (ptid_t ptid)
>> tp->num = ++highest_thread_num;
>> tp->next = thread_list;
>> thread_list = tp;
>> +
>> + observer_notify_new_thread (tp);
>> +
>> return tp;
>> }
>
>
> Now that Joel has requested that I use observer_attach_new_thread for
> annotations this approach doesn't only produce MI output so it needs to
> be conditioned on MI:
>
> @@ -124,6 +124,10 @@ add_thread_silent (ptid_t ptid)
> tp->num = ++highest_thread_num;
> tp->next = thread_list;
> thread_list = tp;
> +
> + if (ui_out_is_mi_like_p (uiout))
> + observer_notify_new_thread (tp);
This patch, IIUC, will cause the new_thread observer to be notified only
in MI mode. Then, no observer except for MI one will ever be called?
Then, why those non-MI observers exist?
Or to put in other way, I think this patch will make you annotation
observers to be never called. Is this what you want?
- Volodya