This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] Fix AIX breakage - Re: [RFA] Keep breakpoints always inserted.
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 4 May 2008 12:33:09 +0400
- Subject: Re: [commit] Fix AIX breakage - Re: [RFA] Keep breakpoints always inserted.
- References: <200805032327.m43NRP7i025358@d12av02.megacenter.de.ibm.com>
On Sunday 04 May 2008 03:27:24 Ulrich Weigand wrote:
> Vladimir Prus wrote:
>
> >@@ -1402,6 +1402,10 @@ handle_inferior_event (struct execution_control_state *ecs)
> > we're attaching or setting up a remote connection. */
> > if (stop_soon == STOP_QUIETLY || stop_soon == NO_STOP_QUIETLY)
> > {
> >+ /* Loading of shared libraries might have changed breakpoint
> >+ addresses. Make sure new breakpoints are inserted. */
> >+ if (!breakpoints_always_inserted_mode ())
> >+ insert_breakpoints ();
> > resume (0, TARGET_SIGNAL_0);
> > prepare_to_wait (ecs);
> > return;
>
> This change completely breaks AIX, as there you'll get TARGET_WAITKIND_LOADED
> during startup (refering to shared libraries used by the *shell* that runs
> before the actual inferior is started). We must not insert breakpoints
> intended for the inferior into the shell ...
>
> Fixed by the patch below. Tested on powerpc-ibm-aix5.3.0.0;
> committed to mainline.
Thanks!
- Volodya