This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Handle DW_AT_const_value/DW_FORM_strp variables
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 25 Apr 2008 11:28:58 -0700
- Subject: Re: Handle DW_AT_const_value/DW_FORM_strp variables
- References: <200804251915.27580.pedro@codesourcery.com>
Hi Pedro,
> gdb/
> 2008-04-25 Pedro Alves <pedro@codesourcery.com>
>
> * dwarf2read.c (dwarf2_const_value): Handle DW_FORM_strp.
>
> gdb/testsuite/
> 2008-04-25 Pedro Alves <pedro@codesourcery.com>
>
> * gdb.dwarf2/dw2-strp.S, gdb.dwarf2/dw2-strp.exp: New files.
Both patches look good to me. Please go ahead and commit.
> +# This test can only be run on targets which support DWARF-2 and use gas.
> +# For now pick a sampling of likely targets.
> +if {![istarget *-*-linux*]
> + && ![istarget *-*-gnu*]
> + && ![istarget *-*-elf*]
> + && ![istarget *-*-openbsd*]
> + && ![istarget arm-*-eabi*]
> + && ![istarget powerpc-*-eabi*]} {
> + return 0
> +}
I wonder if we should put that in a function somewhere. We have been
repeating this pretty large condition in several files, now. Just
thinking out loud...
--
Joel