This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] fix for PR2424
- From: Daniel Jacobowitz <drow at false dot org>
- To: Aleksandar Ristovski <ARistovski at qnx dot com>
- Cc: Vladimir Prus <vladimir at codesourcery dot com>, gdb-patches at sources dot redhat dot com, nickrob at snap dot net dot nz
- Date: Tue, 15 Apr 2008 10:56:52 -0400
- Subject: Re: [patch] fix for PR2424
- References: <4804BF23.10505@qnx.com>
On Tue, Apr 15, 2008 at 10:43:47AM -0400, Aleksandar Ristovski wrote:
> NOTE2: Due to quite significant rework of certain functions in
> mi-support.exp,
> committed diff for testsuite is not exactly the same as the one I posted. I
> took
> liberty to commit anyway since the changes are functionally the same; note
> the
> slightly awkward syntax for "mi_expect_stop" call, namely the "extra"
> argument
> which now must be something like { "" "disp=\"keep\"" } - I don't think it's
> too
> bad (it can be beautified later).
Committing anyway is fine. When you commit a modified version of a
patch, though, please post the final version for the list archives.
Thanks. That way anyone whose code is affected can see the changes.
> NOTE3: In mi-support.exp (mi_expect_stop), I put argument "after_reason" to
> be
> after the reason (I couldn't find it being used anywhere anyway, so this
> should
> be a safe change).
Vladimir presumably has plans for it :-)
> NOTE4: Documentation is not updated (I will try to do that now and submit
> the
> diff for approval).
Thanks.
--
Daniel Jacobowitz
CodeSourcery