This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] pr1430


On Fri, Mar 14, 2008 at 01:38:12PM -0700, Matt Rice wrote:
> here is an attempt at fixing pr1430
> 
> canonicalizes to file.m:foo or file.m:-[AClass foo]
> which is how it knows that foo is a function and it shouldn't attempt
> to look up a method
> named foo. not sure if this should be done in decode_line_2 based on
> language setting?
> 
> so if you move files around or anything you have to reset your
> breakpoints, but i would take that over an endless loop.

This isn't safe; there might not be a filename.  Aren't we getting
canonicalized to file.m:-[AClass foo] already?
build_canonical_line_spec should do it.

A harder version of this problem will come up if you have a
non-debuggable symbol named foo.  We won't have a filename to put
in front of it.  So how do we know it's already been canonicalized?
This is sort of like what the Apple patch did in the audit trail.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]