This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [linux] fix stepping over fork in follow-child mode.

On Thu, Mar 20, 2008 at 10:18:40AM +1200, Nick Roberts wrote:
>  >  /* Building process ids.  */
>  >  
>  >  #define GET_PID(ptid)		ptid_get_pid (ptid)
>  >  #define GET_LWP(ptid)		ptid_get_lwp (ptid)
>  > -#define GET_THREAD(ptid)	ptid_get_tid (ptid)
>  > -
>  > -#define is_lwp(ptid)		(GET_LWP (ptid) != 0)
>  > -#define is_thread(ptid)		(GET_THREAD (ptid) != 0)
>  >  
>  >  #define BUILD_LWP(lwp, pid)	ptid_build (pid, lwp, 0)
> 
> Why not just put all these in linux-nat.h so there are not duplications in
> linux-nat.c?

No particular reason; I just left them where they were.  I believe
they were added to a lot of files when ptid_t was introduced.  May as
well move them, I'll do that.

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]