This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: attach& support, and attach "async + sync_execution" support.
Daniel Jacobowitz wrote:
> On Fri, Mar 14, 2008 at 08:05:39AM +0000, Pedro Alves wrote:
>> 2008-03-14 Pedro Alves <pedro@codesourcery.com>
>>
>> * infcmd.c (attach_command_async_continuation): New.
>> (attach_command): Support background async execution, and async
>> execution in synchronous mode.
>
> Could you do some refactoring on this, please? It duplicates code
> from attach_command.
Right.
> When I fixed up step last year I moved the
> common code into its own function. Makes it much easier to see
> the differences between async and sync operation. And for instance
> it lets me see that you're calling deprecated_attach_hook twice
> in async mode :-)
In fact, it's quite possible to always install continuation, and
then immediately run it in a sync mode. I have a patch doing the same
for finish; guess I better post it now ;-)
- Volodya