This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Implement -thread-info.
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Nick Roberts <nickrob at snap dot net dot nz>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 10 Mar 2008 10:59:11 +0300
- Subject: Re: [RFA] Implement -thread-info.
- References: <200802171833.26673.vladimir@codesourcery.com> <fqucs4$upe$2@ger.gmane.org> <18386.61722.520179.46104@kahikatea.snap.net.nz>
On Saturday 08 March 2008 23:03:38 Nick Roberts wrote:
>
> > -static void
> > -info_threads_command (char *arg, int from_tty)
> > +/* Prints the list of threads and their details on UIOUT.
>
> > + This is a version of 'info_thread_command' suitable for
> > + use from MI.
>
> Isn't this comment out of date now that info_threads_command calls
> mi_info_threads?
It is out of date, indeed.
>
> > + If REQESTED_THREAD is not -1, it's the GDB id of the thread
> > + that should be printed. Otherwise, all threads are
> > + printed. */
> > +void
> > +mi_info_threads (struct ui_out *uiout, int requested_thread)
> > {
>
> As mi_info_threads is now not mi specific, should it be called something like
> info_threads_1?
The "_1" is a bit misleading, as the function can print information about all
threads just fine. How about "print_thread_info"?
- Volodya