Re: [Patch]: Build script gdb_buildall.sh

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Mon, 11 Feb 2008 08:58:57 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> CC: Eli Zaretskii <eliz@gnu.org>, Daniel Jacobowitz <drow@false.org>,
>         Ulrich Weigand <uweigand@de.ibm.com>,
>         Pierre Muller <muller@ics.u-strasbg.fr>
> 
> this patch adds documentation to this patch: http://sourceware.org/ml/gdb-patches/2008-01/msg00671.html. 
> 
> 
> ChangeLog:
> 
> 	
> 	Add script to build and test GDB using enable-targets=all.
> 
> 	* gdb_buildall.sh: New file.
> 
> 
> 
> ChangeLog Doc:
> 
> 	* gdbint.texinfo (Build Script): New section. Mention new build script
> 	gdb_buildall.sh.
> 
> 
> Eli, is the documentation ok? I added a section to "Hints" in gdbint.texinfo.

Yes, except for a few minor gotchas:

> +The script @code{gdb_buildall.sh} builds GDB with flag

gdb_buildall.sh is a file, so please use the @file markup, not @code.

> +@code{--enable-targets=all} set. This builds GDB with all supported targets

Options such as --enable-targets=all should have the @option markup.

> +activated. This helps testing GDB when doing changes that affect more than one
            ^^
Two spaces after a period that ends a sentence.

> +After building GDB the scripts checks which architectures are supported and

We use @value{GDBN} instead of a literal GDB, to allow changing the
name by editing a single line at the beginning of the manual.

Thanks.