This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Disallow pseudo-registers in agent expression.
- From: "Jim Blandy" <jimb at red-bean dot com>
- To: "andrzej zaborowski" <balrogg at gmail dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 5 Feb 2008 07:58:31 -0800
- Subject: Re: [PATCH] Disallow pseudo-registers in agent expression.
- References: <fb249edb0801261107s6444f842s45ef63860c38f4d3@mail.gmail.com> <fb249edb0801261110g75922f69o948a2e2fd6b08dfa@mail.gmail.com> <8f2776cb0801271007r125463e0la1cf8a7c9d1efef@mail.gmail.com> <fb249edb0801281551o68911a0cw5e6d2051247722ab@mail.gmail.com> <8f2776cb0801281728v2ff40d50y2be92664b2c28de5@mail.gmail.com> <8f2776cb0802050734x1f79a335kfa3eaa104f25fedc@mail.gmail.com>
I've committed the following, to fix part of this.
gdb/ChangeLog:
2008-02-05 Jim Blandy <jimb@red-bean.com>
* ax-gdb.c (gen_expr): Yield ordinary error if asked to trace a
pseudoregister, not an internal error.
Reported by: Andrzej Zaborowski
diff -r fb37ff1fb896 -r da7d103c89a5 gdb/ax-gdb.c
--- a/gdb/ax-gdb.c Tue Feb 05 07:36:35 2008 -0800
+++ b/gdb/ax-gdb.c Tue Feb 05 07:56:09 2008 -0800
@@ -1607,6 +1607,10 @@ gen_expr (union exp_element **pc, struct
if (reg == -1)
internal_error (__FILE__, __LINE__,
_("Register $%s not available"), name);
+ if (reg >= gdbarch_num_regs (current_gdbarch))
+ error (_("'%s' is a pseudo-register; "
+ "GDB cannot yet trace pseudoregister contents."),
+ name);
value->kind = axs_lvalue_register;
value->u.reg = reg;
value->type = register_type (current_gdbarch, reg);