This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/RFA] handle function homonyms in breakpoint expressions


On Wed, Jan 02, 2008 at 02:45:06AM -0800, Joel Brobecker wrote:
> > The idea is to short-circuit the end of decode_line_1 and call the
> > Ada-specific part instead, like so:
> > 
> >    else if (current_language->la_language == language_ada)
> >      {
> >        return ada_finish_decode_line_1 (argptr, file_symtab, funfirstline,
> >                                         canonical, not_found_ptr);
> >      }
> 
> Actually, I forgot one small piece.  Inside linespec.c:locate_first_half,
> we need to do handle the parsing a little bit differently for Ada.
> This is because we re-write the breakpoint location expression in
> a canonical form that is unambiguous. For that, we use the form
> FILE:FUN_NAME:LINE_NO. As a result, the parsing needs to be adjusted
> for Ada. We do this by adding the following code in locate_first_half:

Grumble, if this form is better for Ada, is it better for everyone
else too?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]