This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Rethrow exception properly.
On Sunday 27 January 2008 05:18:32 Nick Roberts wrote:
> > Such rethrowing is just wrong -- if we fully delegate handling of
> > the error to our caller, we should just throw the original exception.
> >
> > The attached patch switches to using throw_exception and gets us
> > back to sane MI error message. OK?
>
> There is still the anomaly between break_command_really returning int and
> gdb_breakpoint returning enum gdb_rc. Currently it looks like the return value
> of break_command_1 is not used, so this could presumably be void. If the
> exception handling is all done in break_command_really perhaps we don't need
> the return value of gdb_breakpoint.
That's a topic of separate patch (which will fix yet another problem). This
patch fixes the first apparent issue.
- Volodya