This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove default_gcore_mach from gcore.c
- From: Michael Snyder <msnyder at specifix dot com>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Thu, 17 Jan 2008 13:48:37 -0800
- Subject: Re: [rfc] Remove default_gcore_mach from gcore.c
- References: <478F1CC5.904@de.ibm.com>
On Thu, 2008-01-17 at 10:15 +0100, Markus Deuling wrote:
> Hi,
>
> this patch remvoes default_gcore_mach as it seems to be useless (always returns 0). I tested it on x86 and testsuite showed no
> regressions. What do you think? Is this funtion still useful?
>
> Ok to commit?
I'd prefer you didn't remove it. It's a bit of unfinished
infrastructure, a place holder if you will.
The idea is to someday get the gcore command working on
more generic targets such as "target remote", so that
gdb can suck a corefile image out of them without any
particular help from the native system.
>
>
> ChangeLog:
>
> * gcore.c (default_gcore_mach): Remove.
>
>
> plain text document attachment (diff-gcore)
> diff -urpN src/gdb/gcore.c dev/gdb/gcore.c
> --- src/gdb/gcore.c 2008-01-01 23:53:09.000000000 +0100
> +++ dev/gdb/gcore.c 2008-01-17 09:38:48.000000000 +0100
> @@ -37,7 +37,6 @@
>
> static char *default_gcore_target (void);
> static enum bfd_architecture default_gcore_arch (void);
> -static unsigned long default_gcore_mach (void);
> static int gcore_memory_sections (bfd *);
>
> /* Generate a core file from the inferior process. */
> @@ -78,7 +77,6 @@ gcore_command (char *args, int from_tty)
> old_chain = make_cleanup_bfd_close (obfd);
>
> bfd_set_format (obfd, bfd_core);
> - bfd_set_arch_mach (obfd, default_gcore_arch (), default_gcore_mach ());
>
> /* An external target method must build the notes section. */
> note_data = target_make_corefile_notes (obfd, ¬e_size);
> @@ -118,24 +116,6 @@ gcore_command (char *args, int from_tty)
> return;
> }
>
> -static unsigned long
> -default_gcore_mach (void)
> -{
> -#if 1 /* See if this even matters... */
> - return 0;
> -#else
> -
> - const struct bfd_arch_info *bfdarch = gdbarch_bfd_arch_info (current_gdbarch);
> -
> - if (bfdarch != NULL)
> - return bfdarch->mach;
> - if (exec_bfd == NULL)
> - error (_("Can't find default bfd machine type (need execfile)."));
> -
> - return bfd_get_mach (exec_bfd);
> -#endif /* 1 */
> -}
> -
> static enum bfd_architecture
> default_gcore_arch (void)
> {