This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Remove BITS_BIG_ENDIAN from defs.h


> Date: Fri, 11 Jan 2008 19:18:09 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> 
> this patch removes BITS_BIG_ENDIAN from defs.h by replacing it with its expression. The way to recognize
> endianess of a target is gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG which is widely used by most files.
> So this macro is unnecessary.

Sorry, I don't see how this argument is the proof that the macro is
unnecessary.  defs.h allows a target to define BITS_BIG_ENDIAN, and
only looks at gdbarch_byte_order if BITS_BIG_ENDIAN is undefined.
Your change removes that possibility.  Why is that justified?

The gdbint.texinfo text you want to remove clearly says that this
macro is for the targets whose bit numbering does NOT match the
endianess of the target itself:

> -@item BITS_BIG_ENDIAN
> -@findex BITS_BIG_ENDIAN
> -Define this if the numbering of bits in the targets does @strong{not} match the
> -endianness of the target byte order.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]