This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix parameter coercing for Ada function calls (take 2)


On Tue, Jan 08, 2008 at 10:52:19AM -0800, Joel Brobecker wrote:
> Hi Daniel,
> 
> Does this look like what you had in mind? It's a little more work
> than my first patch, but indeed a little more elegant.

Yes, exactly.

>     If PARAM_TYPE is non-NULL, it is the expected parameter type.
>     IS_PROTOTYPED is non-zero if the function declaration is prototyped.  */

Please add the new parameter to the comment.

>  static struct value *
>  value_arg_coerce (struct value *arg, struct type *param_type,
> -		  int is_prototyped)
> +		  int is_prototyped, CORE_ADDR *pc)

... and call it sp :-)


-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]