This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit/obvious] my horrible typo in dwarf2read.c:read_base_type


#$*%@!

I screwed up in the following checkin:

    2007-12-24  Joel Brobecker  <brobecker@adacore.com>
    
            * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR
            for char and unsigned char types of Ada compilation units.
            * ada-lang.c (ada_is_character_type): Always return true if
            the type code is TYPE_CODE_CHAR.

What happened is that I was working with a set of sources which
where almost current but also had some local changes. When I tried
to apply the patch from that tree into a pure FSF tree, it failed,
so I did the change manually, and then tested against the testsuite.
Of course, no failure, so I committed the change.

Fortunately, a problem that I suspected would happen on x86_64 actually
didn't show up, which puzzled me. So I started investigating, and
found this horrible typo.

I am very sorry for letting this through - I will be more careful.
Fixed thusly:

2007-12-26  Joel Brobecker  <brobecker@adacore.com>

        * dwarf2read.c (read_base_type): Fix obvious &&/|| confusion.

Checked in.

-- 
Joel

Attachment: dw2.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]