This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: Use gdb_get_line_number in asm-source.exp
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jim Blandy <jimb at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 22 Dec 2007 10:26:04 +0400
- Subject: Re: RFA: Use gdb_get_line_number in asm-source.exp
- References: <m3sl1v8dwh.fsf@codesourcery.com>
Hi Jim,
> 2007-12-21 Jim Blandy <jimb@codesourcery.com>
>
> * gdb.asm/asm-source.exp: Use gdb_get_line_number, instead of
> hard-coding source line numbers into the test.
> * gdb.asm/asmsrc1.s, gdb.asm/asmsrc2.s: Add comments for
> gdb_get_line_number to find.
FWIW, this looks good to me. There is just ...
> comment "Call a subroutine in another file."
>
> + comment "mark: call foo2"
> gdbasm_call foo2
The indenting here that looks a bit strange.
--
Joel