This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Use gdb_get_line_number in asm-source.exp


Hi Jim,

> 2007-12-21  Jim Blandy  <jimb@codesourcery.com>
> 
> 	* gdb.asm/asm-source.exp: Use gdb_get_line_number, instead of
> 	hard-coding source line numbers into the test.
> 	* gdb.asm/asmsrc1.s, gdb.asm/asmsrc2.s: Add comments for
> 	gdb_get_line_number to find.

FWIW, this looks good to me. There is just ...

>  	comment "Call a subroutine in another file."
>  
> +        comment "mark: call foo2"
>  	gdbasm_call foo2

The indenting here that looks a bit strange.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]