This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gdbserver/win32] (3/11) Fix suspend count handling



Just a couple small tiny details:


Not that it's super important, but in all the series of patches where both our names appear, I think my name should be listed second (if at all) in the changelog, as Pedro did the vast majority of the work for these patches, and merged with the one I sent.
What's fair, is fair, I think. :)


Also, is it necessary to include the eMail?
I'd prefer not to include mine if this is possible, if this can lower spam getting into my mail box.





Daniel Jacobowitz escribió:
On Mon, Nov 12, 2007 at 02:06:59AM +0000, Pedro Alves wrote:
I have yet to turn this into a proper gdb test. Is that wanted? Where
shall I put it? gdb.base? gdb.thread? other?

gdb.threads would be good, I think.


2007-11-12  Leo Zayas  <lerele@champenstudios@com>
	    Pedro Alves  <pedro_alves@portugalmail.pt>

	* win32-low.h (win32_thread_info): Add descriptions to the
	structure members .  Replace `suspend_count' counter by a
	`suspended' flag.

* win32-low.c (thread_rec): Update condition of when to get the
context from the inferior. Rely on ContextFlags being set if it
has already been retrieved. Only suspend the inferior thread if
we haven't already. Warn if that fails.
(continue_one_thread): s/suspend_count/suspended/. Only call
ResumeThread once. Warn if that fails.

OK.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]