This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [win32] Fix suspend count handling
On Sat, Nov 24, 2007 at 03:18:42PM +0100, Lerele wrote:
>>> Christopher Faylor escribi?:
>>>> I have to ask, however, if the SuspendThread's are even needed at all.
>>>> When I was writing this code, I wasn't entirely sure that gdb needed to
>>>> do anything like this but I erred on the side of caution. So, I'm
>>>> wondering if things would still work ok if the
>>>> SuspendThread/ResumeThread stuff was gone.
>>>>
>>> I think they are needed. They were anyway with the new gdbserver based
>>> (vs. Win32 API based) interrupt code I sent several days ago, and that
>>> so very kindly Pedro prepared for commitment, but that I still haven't
>>> found the time to sit down and look at them (however I'm absolutely
>>> sure they're just fine), I guess his changes must be similar to what I
>>> sent in the first place.
>>>
>>
>> *Why* did you think you needed them in gdbserver? Did you actually try
>> not using them or did you just copy my code from win32-nat.c?
>
> I thought it natural to implement win32 functionality into gdbserver not
> starting from scratch, but from an already working implementation, such as
> win32-nat.c, however *truly* one drawback of this is that original code
> bugs got inherited into new implementation (such as the subject in
> question), and the porting process however was not really as
> straightforward as copy/paste; certain amount of work was involved (a lot
> of debugging gdbserver and gdb themselves), however I did not stop to think
> that SuspendThread was not actually needed, as it was already there.
So, in answer to my question about whether something was needed or not,
you asserted that it wasn't needed because you copied the code that I
wrote which was the source of my question. Sorry but that doesn't really
answer my question.
If Windows already does the SuspendThread on all threads on debug event
then there is no reason to also do it in gdb. I was asking if anyone
had actually checked if that was the case since it has been quite some
time since I did any experiments.
cgf