This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [win32] Fix watchpoint support


Christopher Faylor wrote:

2007-11-21 Pedro Alves <pedro_alves@portugalmail.pt>

	* win32-nat.c (win32_add_thread): Set Dr6 to 0xffff0ff0.
	(win32_continue): Resume threads and set the debug registers
	before calling ContinueDebugEvent.

I'm not clear on how this differs from your other patch. It seems to do many of the same things. The principles are ok but it doesn't seem like it could be applied in addition to the suspend count handling patch.


Oh, that's because the last patch I sent on the other thread had this one merged in [1], because after discussing it with Pierre, we came to the conclusion this was needed for a full fix of the other bug. I though merging it would be better for you, since you'd only need to review one patch. I was wrong then. Sorry. :/

[1]
http://sourceware.org/ml/gdb-patches/2007-11/msg00402.html

Cheers,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]