This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] [05/09] Get rid of current_gdbarch (macros in mn10300 target)


Markus Deuling wrote:

> 	* mn10300-tdep.c (set_reg_offsets,mn10300_analyze_prologue): Replace
> 	AM33 by its expression. Use get_frame_arch to get at the current
> 	architecture by frame_info.
> 	* mn10300-tdep.h (AM33_MODE): Remove.

Sorry, but this is not OK.  Unfortunately, the mn10300_analyze_prologue
routine is called both from within the unwinder (where we always have
a frame), *and* from mn10300_skip_prologue, where frame information is
not available.  Thus "fi" may actually be NULL.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]