This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c


> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Mark Kettenis
> Sent: Monday, October 08, 2007 3:27 PM
> To: muller@ics.u-strasbg.fr
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-
> fork.c
> 
> > From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> > Date: Mon, 8 Oct 2007 14:35:01 +0200
> >
> >  This one is almost like the previous that fixed the wait header.
> >
> > OK to commit?
> 
> It probably doesn't matter on Linux, but in general it is better to
> leave the headers in the same order when replacing <xxx.h> with
> "gdb_xxx.h".

  Maybe, but in my latest commit to linux-fork.c I did exactly
the same operation for the wait header, and moved it up from
the system <header.h> includes to the local "header.h" includes,
and Joel told me that this was the right thing to do...

See the
http://sourceware.org/ml/gdb-patches/2007-10/msg00044.html
thread.

Pierre





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]