This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR pascal/2283

From: Jonas Maebe <jonas at freepascal dot org>
To: Eli Zaretskii <eliz at gnu dot org>
Cc: muller at ics dot u-strasbg dot fr, gdb-patches at sourceware dot org
Date: Wed, 26 Sep 2007 16:13:50 +0200
Subject: Re: [PATCH] Fix PR pascal/2283
References: <002f01c80038$5881a880$0984f980$@u-strasbg.fr> <uzlz95yg7.fsf@gnu.org> <36AA51D7-8F6A-41D6-82F2-5E837D169AB9@freepascal.org> <utzph5xl6.fsf@gnu.org>

On 26 Sep 2007, at 16:07, Eli Zaretskii wrote:

Cc: "Pierre Muller" <muller@ics.u-strasbg.fr>,
	gdb-patches@sourceware.org
From: Jonas Maebe <jonas@freepascal.org>
Date: Wed, 26 Sep 2007 16:03:13 +0200

In fact, I have no idea why that code (in both the Pascal and
Modula-2 cases) even checks the current language, as those routines
are obviously language-specific.


Exactly!  If this code is Pascal-specific, you shouldn't be checking
the language at all.

In that case, the Modula-2 version shouldn't either. But I'm far too unfamiliar with the gdb source base to be able to assess whether it is in fact correct and safe to remove those checks.

Jonas

References:
- [PATCH] Fix PR pascal/2283
  - From: Pierre Muller
- Re: [PATCH] Fix PR pascal/2283
  - From: Eli Zaretskii
- Re: [PATCH] Fix PR pascal/2283
  - From: Jonas Maebe
- Re: [PATCH] Fix PR pascal/2283
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]