Re: [patch] tui: initialize signal handler

[Pedro Alves <pedro_alves at portugalmail dot pt>]

(Eli, Apologies for misspelling you name upthread.)

Carlos Eduardo Seo wrote:
> Updated patch with your suggestions.

Thanks.

You shouldn't wrap the whole tui_initialize_win in ifdef
SIGWINCH, but it's contents instead, else on a system
without SIGWINCH, you'll get an undefined reference to
tui_initialize_win.

Other than that, it looks good to me, but, you'll need approval
from a responsible or global maintainer.

> 2007-09-22   Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
            ^^^                  ^
It should be two spaces before and after the name.

> 	gdb/tui/tui-interp.c (tui_init): initialize
> 	tui's SIGWINCH signal handler.
> 	gdb/tui/tui-win.c (tui_initialize_win): new
> 	function for initializing tui's SIGWINCH signal
> 	handler.
> 	gdb/tui/tui-win.h (tui_initialize_win): added

Remove "gdb/" from the path of the changed files, since the path
is relative to the ChangeLog file location.  Add "* " in front,
Capitalize the sentences and finish them with a full stop. Eg:

2007-09-22  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>

	* tui/tui-interp.c (tui_init): Initialize tui's
	SIGWINCH signal handler.
	* tui/tui-win.c (tui_initialize_win): New.
	function for initializing tui's SIGWINCH signal
	handler.
	* tui/tui-win.h (tui_initialize_win): Declare.

Cheers,
Pedro Alves