This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Multi-threaded watchpoints, GNU/Linux native bits


>  static int
> -ppc_linux_stopped_by_watchpoint (void)
> +ppc_linux_stopped_data_address (struct target_ops *target, CORE_ADDR *addr_p)
>  {
> -  int tid;
> -  struct siginfo siginfo;
> -  ptid_t ptid = inferior_ptid;
> +  struct siginfo *siginfo_p;
>    CORE_ADDR *addr_p;
> 
> -  tid = TIDGET(ptid);
> -  if (tid == 0)

Quick comment:

"CORE_ADDR *addr_p" right below "siginfo_p" should be eliminated since
we're already getting that parameter from the function call.

Regards,
 
Luis Machado
IBM Linux Technology Center
e-mail: luisgpm@linux.vnet.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]