This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Multi-threaded watchpoints, GNU/Linux native bits
- From: Luis Machado <luisgpm at linux dot vnet dot ibm dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 17 Sep 2007 11:15:04 -0300
- Subject: Re: [rfc] Multi-threaded watchpoints, GNU/Linux native bits
- References: <20070916185734.GA24815@caradoc.them.org>
- Reply-to: luisgpm at linux dot vnet dot ibm dot com
> static int
> -ppc_linux_stopped_by_watchpoint (void)
> +ppc_linux_stopped_data_address (struct target_ops *target, CORE_ADDR *addr_p)
> {
> - int tid;
> - struct siginfo siginfo;
> - ptid_t ptid = inferior_ptid;
> + struct siginfo *siginfo_p;
> CORE_ADDR *addr_p;
>
> - tid = TIDGET(ptid);
> - if (tid == 0)
Quick comment:
"CORE_ADDR *addr_p" right below "siginfo_p" should be eliminated since
we're already getting that parameter from the function call.
Regards,
Luis Machado
IBM Linux Technology Center
e-mail: luisgpm@linux.vnet.ibm.com