This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: readline/util.c, resource leak
- From: Jim Blandy <jimb at codesourcery dot com>
- To: msnyder at sonic dot net
- Cc: gdb-patches at sourceware dot org, bug-readline at gnu dot org
- Date: Tue, 14 Aug 2007 16:41:56 -0700
- Subject: Re: PATCH: readline/util.c, resource leak
- References: <21219.12.7.175.2.1185934372.squirrel@webmail.sonic.net>
Looks right to me.
msnyder@sonic.net writes:
> 2007-07-31 Michael Snyder <msnyder@access-company.com>
>
> * util.c (rl_tilde_expand): Resource leak.
>
> Index: util.c
> ===================================================================
> RCS file: /cvs/src/src/readline/util.c,v
> retrieving revision 1.6
> diff -p -r1.6 util.c
> *** util.c 5 May 2006 18:26:12 -0000 1.6
> --- util.c 1 Aug 2007 01:54:07 -0000
> *************** rl_tilde_expand (ignore, key)
> *** 185,190 ****
> --- 185,191 ----
> {
> homedir = tilde_expand ("~");
> _rl_replace_text (homedir, start, end);
> + free (homedir);
> return (0);
> }
> else if (rl_line_buffer[start] != '~')
> *************** rl_tilde_expand (ignore, key)
> *** 215,220 ****
> --- 216,222 ----
> free (temp);
>
> _rl_replace_text (homedir, start, end);
> + free (homedir);
> }
>
> return (0);