This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] dead code in mi-interp

From: Daniel Jacobowitz <drow at false dot org>
To: Nick Roberts <nickrob at snap dot net dot nz>
Cc: msnyder at sonic dot net, gdb-patches at sourceware dot org
Date: Thu, 9 Aug 2007 10:57:27 -0400
Subject: Re: [PATCH] dead code in mi-interp
References: <17268.12.7.175.2.1186611933.squirrel@webmail.sonic.net> <18106.20613.121153.810889@kahikatea.snap.net.nz>

On Thu, Aug 09, 2007 at 11:23:49AM +1200, Nick Roberts wrote:
>  > Must have been meant for something, but seems to have no side effects.
> 
> There are probably no side effects because currently target_can_async_p ()
> usually returns 0.  I hope to add an option to make GDB work asynchronously
> after 6.7 is released.  Maybe this still won't be needed but I don't really
> like these kinds of changes.  As they say: "If it ain't broke, don't fix it.".
> There must be larger cobwebs to blow away.

That's not what "no side effects" means - the code literally can't
ever have an effect.  It creates a string which nothing uses.  Why
keep it?

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: [PATCH] dead code in mi-interp
  - From: Nick Roberts

References:
- [PATCH] dead code in mi-interp
  - From: msnyder
- Re: [PATCH] dead code in mi-interp
  - From: Nick Roberts

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]