This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] target_read_string, potential memory leak.

From: msnyder at sonic dot net
To: "Jim Blandy" <jimb at codesourcery dot com>
Cc: msnyder at sonic dot net, gdb-patches at sourceware dot org
Date: Wed, 8 Aug 2007 11:32:38 -0700 (PDT)
Subject: Re: [patch] target_read_string, potential memory leak.
References: <13153.12.7.175.2.1186284546.squirrel@webmail.sonic.net> <m3tzrc47or.fsf@codesourcery.com>

>
> msnyder@sonic.net writes:
>> OK -- it would be pretty stupid to call target_read_string without
>> passing it a buffer, but if we're going to check it for null...
>
> I don't think the contract for target_read_string permits STRING to be
> null.  I think either the test should go, or we should add a
> gdb_assert (string).

Agreed.  Thus?

Attachment: target_string.txt
Description: Text document

Follow-Ups:
- Re: [patch] target_read_string, potential memory leak.
  - From: Jim Blandy

References:
- [patch] target_read_string, potential memory leak.
  - From: msnyder
- Re: [patch] target_read_string, potential memory leak.
  - From: Jim Blandy

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]