This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Detect dwarf address size mismatch


> Date: Tue, 17 Jul 2007 08:47:11 -0400
> From: Daniel Jacobowitz <drow@false.org>

Hi Daniel,

Sorry I didn't notice this before but:

> @@ -6792,6 +6793,15 @@ dwarf_decode_lines (struct line_header *
>  			     _("mangled .debug_line section"));
>  		  return;
>  		}
> +	      /* Make sure that we parsed the extended op correctly.  If e.g.
> +		 we expected a different address size than the producer used,
> +		 we may have read the wrong number of bytes.  */
> +	      if (line_ptr != extended_end)
> +		{
> +		  complaint (&symfile_complaints,
> +			     _("mangled .debug_line section"));
> +		  return;
> +		}
>  	      break;
>  	    case DW_LNS_copy:
>  	      if (lh->num_file_names < file)

The complaint "mangled .debug_line section" seems a bit unhelpful to
me, especially since there are now two identical messages for what
appears to be somewhat different conditions.  Any chance of changing
it something more distinguishable?

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]