This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING 2] [rfc]: Framework for looking up multiply defined global symbols in shared libraries


Markus Deuling wrote:

> 	* cp-namespace.c (lookup_symbol_file): Add block to
> 	lookup_symbol_global call.
> 	* Makefile.in (solist_h): Add dependency on symtab header.
> 	(symtab.o): Add dependency on solist header.
> 	* solib.c (solib_global_lookup): New function.
> 	* solib-svr4.c (scan_dyntag): Likewise.
> 	(elf_locate_base): Call helper routine scan_dyntag.
> 	(elf_lookup_lib_symbol): New function.
> 	(_initialize_svr4_solib): Add elf_lookup_lib_symbol to svr4_so_ops.
> 	* solist.h (symtab.h): New include.
> 	(lookup_lib_global_symbol): New prototype.

I guess this should read:
	(struct target_so_ops): New member lookup_lib_global_symbol.

> 	(solib_global_lookup): Likewise.
> 	* symtab.c: New include solist.h.
> 	(lookup_objfile_from_block): New function.
> 	(lookup_global_symbol_from_objfile): New function.
> 	(basic_lookup_symbol_nonlocal): Add block to lookup_symbol_global call.
> 	(lookup_symbol_global): Call library-specific lookup procedure.
> 	* symtab.h (lookup_global_symbol_from_objfile): New prototype.

> 	* gdb.base/libmd.c: New file (testcase multiple symbol lookup).
> 	* gdb.base/libmd.h: Likewise.
> 	* gdb.base/solib_symbol.c: Likewise.
> 	* gdb.base/solib_symbol.exp: Likewise.

And those file names have changed in the latest version:
	* gdb.base/solib-symbol.exp: New file (testcase multiple symbol lookup).
	* gdb.base/solib-symbol-lib.c: Likewise.
	* gdb.base/solib-symbol-main.c: Likewise.

I've committed the patch with the above ChangeLog changes now.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]