This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Overflow in transfer-rate
- From: Denis PILAT <denis dot pilat at st dot com>
- To: Denis PILAT <denis dot pilat at st dot com>, Andrew STUBBS <andrew dot stubbs at st dot com>, gdb-patches <gdb-patches at sourceware dot org>, Ilko Iliev <iliev at ronetix dot at>
- Date: Mon, 02 Jul 2007 09:35:38 +0200
- Subject: Re: [rfc] Overflow in transfer-rate
- References: <466D3A7D.9030101@st.com> <466D456F.5070406@st.com> <466D4AFD.8070409@st.com> <20070701221010.GA30560@caradoc.them.org>
Daniel Jacobowitz wrote:
On Mon, Jun 11, 2007 at 03:15:41PM +0200, Denis PILAT wrote:
Andrew STUBBS wrote:
Denis PILAT wrote:
In symfile.c/print_transfer_performance (), an overflow can occure when
data_count (see below) is a large number.
I propose either the following 1st patch, or to pass to "%llu"into the
ui_out_field_fmt functino call, see the next patch proposal.
I might also be worth taking a look at this proposal from some time ago
http://www.cygwin.com/ml/gdb-patches/2006-10/msg00184.html
Well, it sounds like an internal ST discussion but I prefer the patch in your
link, it avoids overflow *and* prints transfer rate in a much clever way.
How about this version, then? I left GDB/MI behavior unchanged, so
that this does not break GUIs.
Hi Daniel,
You're right, we must not break MI based GUI, I'm fine with your proposal.
I guess it will be include in 6.8 , not 6.7 GDB version ?
Thanks,
Denis