Re: [rfc] [2/6] Remove macro TARGET_BYTE_ORDER

[Markus Deuling <deuling at de dot ibm dot com>]

Ulrich Weigand wrote:
> Markus Deuling wrote:
>
> > it seems that the TARGET_BYTE_ORDER patch was missing some pieces, so that not all 
> > appearance of it were replaced. So here is "the rest" of the patch. I run gdb_mbuild.sh 
> > and let it build all targets. They were build cleanly. Sorry for the inconvenience.
>
> Sorry, I didn't notice this either when committing that patch.  Thanks for the fix!
>
> > 	* xtensa-tdep.c (XTENSA_IS_ENTRY,extract_call_winsize)
> > 	(xtensa_register_write_masked,xtensa_register_read_masked)

<..>

> > 	* coffread.c (process_coff_symbol): Likewise.
> > 	* arm-tdep.c (convert_from_extended,convert_to_extended)
> > 	(gdb_print_insn_arm): Likewise.
>
> You should have a space after each comma.  Also, this line:
>
> > diff -urN src/gdb/mips-linux-tdep.c dev/gdb/mips-linux-tdep.c
> > --- src/gdb/mips-linux-tdep.c	2007-05-31 19:31:37.000000000 +0200
> > +++ dev/gdb/mips-linux-tdep.c	2007-05-31 21:09:14.000000000 +0200
> > @@ -852,7 +854,7 @@
> >       layout, since we can't tell, and it's much more common.  Which bits are
> >       the "high" bits depends on endianness.  */
> >    for (ireg = 0; ireg < 32; ireg++)
> > -    if ((TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) != (ireg & 1))
> > +    if (gdarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG) != (ireg & 1)
>
> needs to read:
>     if ((gdbarch_byte_order (current_gdbarch) == BFD_ENDIAN_BIG) != (ireg & 1))
>
>
> The rest looks OK, I've committed the patch with those two changes now.

Thank you very much.

--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com