This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [1/6] Remove macro CALL_DUMMY_LOCATION
- From: Jim Blandy <jimb at codesourcery dot com>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Wed, 30 May 2007 14:12:31 -0700
- Subject: Re: [rfc] [1/6] Remove macro CALL_DUMMY_LOCATION
- References: <465BD442.4080300@de.ibm.com>
Markus Deuling <deuling@de.ibm.com> writes:
> this patch removes CALL_DUMMY_LOCATION macro from gdbarch.sh.
>
> ChangeLog:
>
> * gdbarch.sh (CALL_DUMMY_LOCATION): Replace by
> gdbarch_call_dummy_location.
> * infcall.c (call_function_by_hand): Likewise.
> * inferior.h: Change comment.
> * arch-utils.c: Change comment.
> * gdbarch.c, gdbarch.h: Regenerate.
>
>
> Is this ok to commit?
This looks good --- thank you!
But before you commit:
- Are your copyright papers in order? I don't see your name appearing
in the FSF's lists at all; Ulrich's does.
- It seems that others have been committing those patches of yours
that have been approved so far; unless the answer to the first
question bears on this somehow, you should have your own account on
sourceware, and be added to the "Write After Approval" list.